https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/69734
>From a0b9798dc87b313d9dff08e9fa109bf2d65a863e Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri <ar.ashouri...@gmail.com> Date: Sun, 26 Nov 2023 15:06:32 +0330 Subject: [PATCH] [clang] Non-object types are non-trivially relocatable Both active C++ proposals (P1144 and P2786) agree that `is_trivially_relocatable_v<int&>` and `is_trivially_relocatable_v<int()>` should be false, not true. Only complete object types can be trivially relocatable. Fixes #67498 --- clang/docs/ReleaseNotes.rst | 3 +++ clang/lib/AST/Type.cpp | 2 ++ clang/test/SemaCXX/type-traits-incomplete.cpp | 8 +++++++- clang/test/SemaCXX/type-traits-nonobject.cpp | 16 ++++++++++++++++ 4 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 clang/test/SemaCXX/type-traits-nonobject.cpp diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index e2e8ee8d76d2e10..8825fc03bf2d59f 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -640,6 +640,9 @@ Bug Fixes in This Version - Fix crash when the object used as a ``static_assert`` message has ``size`` or ``data`` members which are not member functions. - Support UDLs in ``static_assert`` message. +- ``__is_trivially_relocatable`` no longer returns true for non-object types + such as references and functions. + Fixes (`#67498 <https://github.com/llvm/llvm-project/issues/67498>`_) Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/AST/Type.cpp b/clang/lib/AST/Type.cpp index c8e452e2feab0bf..160a725939ccd4c 100644 --- a/clang/lib/AST/Type.cpp +++ b/clang/lib/AST/Type.cpp @@ -2649,6 +2649,8 @@ bool QualType::isTriviallyRelocatableType(const ASTContext &Context) const { if (BaseElementType->isIncompleteType()) { return false; + } else if (!BaseElementType->isObjectType()) { + return false; } else if (const auto *RD = BaseElementType->getAsRecordDecl()) { return RD->canPassInRegisters(); } else { diff --git a/clang/test/SemaCXX/type-traits-incomplete.cpp b/clang/test/SemaCXX/type-traits-incomplete.cpp index c0a520e167698af..3e341d648244075 100644 --- a/clang/test/SemaCXX/type-traits-incomplete.cpp +++ b/clang/test/SemaCXX/type-traits-incomplete.cpp @@ -1,8 +1,14 @@ // RUN: %clang_cc1 -fsyntax-only -verify %s -struct S; // expected-note 2 {{forward declaration of 'S'}} +struct S; // expected-note 6 {{forward declaration of 'S'}} void f() { __is_pod(S); // expected-error{{incomplete type 'S' used in type trait expression}} __is_pod(S[]); // expected-error{{incomplete type 'S' used in type trait expression}} + + __is_trivially_copyable(S); // expected-error{{incomplete type 'S' used in type trait expression}} + __is_trivially_copyable(S[]); // expected-error{{incomplete type 'S' used in type trait expression}} + + __is_trivially_relocatable(S); // expected-error{{incomplete type 'S' used in type trait expression}} + __is_trivially_relocatable(S[]); // expected-error{{incomplete type 'S' used in type trait expression}} } diff --git a/clang/test/SemaCXX/type-traits-nonobject.cpp b/clang/test/SemaCXX/type-traits-nonobject.cpp new file mode 100644 index 000000000000000..c9e3c30e5533d48 --- /dev/null +++ b/clang/test/SemaCXX/type-traits-nonobject.cpp @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +// expected-no-diagnostics + +static_assert(!__is_pod(void), ""); +static_assert(!__is_pod(int&), ""); +static_assert(!__is_pod(int()), ""); + +static_assert(!__is_trivially_copyable(void), ""); +static_assert(!__is_trivially_copyable(int&), ""); +static_assert(!__is_trivially_copyable(int()), ""); + +static_assert(!__is_trivially_relocatable(void), ""); +static_assert(!__is_trivially_relocatable(int&), ""); +static_assert(!__is_trivially_relocatable(int()), ""); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
