banach-space wrote:

> > LGTM, thank you for taking care of this đŸ™đŸ»
> > Dare I ask - what's "dupes"? I only found 
> > [dupe](https://dictionary.cambridge.org/dictionary/english/dupe). Also, 
> > please wait for @kiranchandramohan to approve before merging this :)
> 
> I used "dupes" in the sense of being fooled. I can of course still change the 
> name to something like "main_linktime_duplicate.f90" or the likes.

Right, "dupes" wasn't that obvious to me :) I would probably go for your other 
suggestion or just plain "duplicate_main.f90". Either would be a bit more 
descriptive IMHO đŸ™đŸ» .

Thanks again for addressing my comments and for this contribution!

https://github.com/llvm/llvm-project/pull/73124
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to