banach-space wrote:

> Could you add some tests? In e.g. "driver-help.f90" we merely test that a 
> flag is visible.

I see that you added 
[frame-pointer-codegen.f90](https://github.com/llvm/llvm-project/pull/72146/files#diff-76ca50365c8a0eb4797ce10b121021e7da52cc86523d806e1ade530a897de7e8),
 but that does not test how flags added in this patch impact code-gen. Please 
add a test that will demonstrate how this flag impacts the generated code.

https://github.com/llvm/llvm-project/pull/72146
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to