NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin, alexfh. NoQ added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz.
ASTMatchers are sometimes handy in the Analyzer, and there are more patches to make use of them. However, it turns out that not only the Analyzer, but also the whole clang binary was never linked to libASTMatchers. So there's a binary size concern. On my machine (mac) binary size increases by: - 0.5% (73 731 296 bytes => 74 118 172 bytes) in release mode, - 2% (243 942 672 bytes => 249 748 052 bytes) in debug mode. Is such increase bearable? Would anybody approve that? https://reviews.llvm.org/D25429 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt Index: lib/StaticAnalyzer/Checkers/CMakeLists.txt =================================================================== --- lib/StaticAnalyzer/Checkers/CMakeLists.txt +++ lib/StaticAnalyzer/Checkers/CMakeLists.txt @@ -91,6 +91,7 @@ LINK_LIBS clangAST + clangASTMatchers clangAnalysis clangBasic clangLex
Index: lib/StaticAnalyzer/Checkers/CMakeLists.txt =================================================================== --- lib/StaticAnalyzer/Checkers/CMakeLists.txt +++ lib/StaticAnalyzer/Checkers/CMakeLists.txt @@ -91,6 +91,7 @@ LINK_LIBS clangAST + clangASTMatchers clangAnalysis clangBasic clangLex
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
