malcolm.parsons added a comment. In https://reviews.llvm.org/D25316#565567, @Prazek wrote:
> functionDecl(hasName(LEXICAL_CAST_NAME))))), I was trying to avoid specifying the name of the function so that it works for any templated function/member function that returns its first template type. ================ Comment at: test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp:25 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use auto when initializing with a cast to avoid duplicating the type name + // CHECK-FIXES: auto ll = static_cast<long long>(l); + unsigned long long ull = static_cast<unsigned long long>(l); ---------------- Prazek wrote: > malcolm.parsons wrote: > > Prazek wrote: > > > Is it possible to simply fix the double spaces? > > The existing modernize-use-auto tests have the same problem. > > My codebase is clang-formatted regularly so it doesn't bother me. > I agree that it is not huge problem with clang-format and of course it is not > required to fix it to push this patch upstream. It would be good to leave a > comment somewhere with FIXME: about this, so it would be easier for some > other contributor to fix it (or if it simple, just fix it in this patch :)) There's a FIXME comment in one of the existing modernize-use-auto test files. https://reviews.llvm.org/D25316 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
