joker-eph wrote: > tests will fail locally but pass everywhere else (for example, people > working on slightly out-of-norm configurations will sometimes have persistent > local failures that are unrelated to changes in the patch).
It never happened to me, in a way that can't be root caused and fixed (that is for example cases like that would be the name of my directory interfere with a CHECK somehow), what do you have in mind? > When precommit CI comes back green or with only false positives The point of my message was that the CI wasn't a false positive: the CI didn't run. A false positive would be seeing a "Passed" for the test that you see failing locally. > speculative commits to see whether an issue "is real" or not do happen on > occasion and are appropriate The cases I have seen for "speculative commits" are the opposite of what you're describing: iterating on issues that only happens on a bot and not reproducible locally. That is you **have** to push a commit because this is the only way to iterate on debugging an issue. Pushing a commit when you have a local failure seems backward to me, I don't quite follow actually. https://github.com/llvm/llvm-project/pull/71322 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
