https://github.com/AMP999 updated
https://github.com/llvm/llvm-project/pull/69734
>From a67c7b8f2af625145c805240fc51f1ecea392ef2 Mon Sep 17 00:00:00 2001
From: Amirreza Ashouri <ar.ashouri...@gmail.com>
Date: Sat, 7 Oct 2023 15:18:55 +0330
Subject: [PATCH] [clang] Non-object types are non-trivially relocatable
Both active C++ proposals (P1144 and P2786) agree that
`is_trivially_relocatable_v<int&>` and `is_trivially_relocatable_v<int()>`
should be false, not true. Only complete object types
can be trivially relocatable.
Fixes #67498
---
clang/lib/AST/Type.cpp | 2 ++
clang/test/SemaCXX/type-traits-incomplete.cpp | 8 +++++++-
clang/test/SemaCXX/type-traits-nonobject.cpp | 16 ++++++++++++++++
3 files changed, 25 insertions(+), 1 deletion(-)
create mode 100644 clang/test/SemaCXX/type-traits-nonobject.cpp
diff --git a/clang/lib/AST/Type.cpp b/clang/lib/AST/Type.cpp
index 4dd4e926c8104a4..4d3cf937d36b904 100644
--- a/clang/lib/AST/Type.cpp
+++ b/clang/lib/AST/Type.cpp
@@ -2648,6 +2648,8 @@ bool QualType::isTriviallyRelocatableType(const
ASTContext &Context) const {
if (BaseElementType->isIncompleteType()) {
return false;
+ } else if (!BaseElementType->isObjectType()) {
+ return false;
} else if (const auto *RD = BaseElementType->getAsRecordDecl()) {
return RD->canPassInRegisters();
} else {
diff --git a/clang/test/SemaCXX/type-traits-incomplete.cpp
b/clang/test/SemaCXX/type-traits-incomplete.cpp
index c0a520e167698af..3e341d648244075 100644
--- a/clang/test/SemaCXX/type-traits-incomplete.cpp
+++ b/clang/test/SemaCXX/type-traits-incomplete.cpp
@@ -1,8 +1,14 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
-struct S; // expected-note 2 {{forward declaration of 'S'}}
+struct S; // expected-note 6 {{forward declaration of 'S'}}
void f() {
__is_pod(S); // expected-error{{incomplete type 'S' used in type trait
expression}}
__is_pod(S[]); // expected-error{{incomplete type 'S' used in type trait
expression}}
+
+ __is_trivially_copyable(S); // expected-error{{incomplete type 'S' used in
type trait expression}}
+ __is_trivially_copyable(S[]); // expected-error{{incomplete type 'S' used in
type trait expression}}
+
+ __is_trivially_relocatable(S); // expected-error{{incomplete type 'S' used
in type trait expression}}
+ __is_trivially_relocatable(S[]); // expected-error{{incomplete type 'S' used
in type trait expression}}
}
diff --git a/clang/test/SemaCXX/type-traits-nonobject.cpp
b/clang/test/SemaCXX/type-traits-nonobject.cpp
new file mode 100644
index 000000000000000..c9e3c30e5533d48
--- /dev/null
+++ b/clang/test/SemaCXX/type-traits-nonobject.cpp
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s
+
+// expected-no-diagnostics
+
+static_assert(!__is_pod(void), "");
+static_assert(!__is_pod(int&), "");
+static_assert(!__is_pod(int()), "");
+
+static_assert(!__is_trivially_copyable(void), "");
+static_assert(!__is_trivially_copyable(int&), "");
+static_assert(!__is_trivially_copyable(int()), "");
+
+static_assert(!__is_trivially_relocatable(void), "");
+static_assert(!__is_trivially_relocatable(int&), "");
+static_assert(!__is_trivially_relocatable(int()), "");
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
