rnk added inline comments.

> CodeGenModule.cpp:512-513
>    }
> +  // Clear the deferred diags so they don't outlive the ASTContext from 
> whence
> +  // they're allocated.
> +  DeferredDiags.clear();

The ASTContext outlives CodeGenModule, but the diagnostic allocator in the 
ASTContext does not. As written, this suggests that CGM outlives ASTContext, 
which isn't right.

https://reviews.llvm.org/D25260



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to