WenleiHe wrote:

> > > This should works with PGO when value profiling is disabled
> > 
> > 
> > Is this not compatible with value profiling? or just not implemented yet?
> 
> Not compatible, but this feature is mainly for coverage testing.

Ok, not a big deal as it's probably not worth the effort. But it would be nice 
if metadata can be separated out orthogonal to functionality, so things work in 
unified way with less special case. Just like debug info can be in a standalone 
binary (with gnu_debuglink), or in the original ELF binary, and they work 
equivalently for symbolization. 

https://github.com/llvm/llvm-project/pull/69493
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to