dcoughlin requested changes to this revision.
dcoughlin added a comment.
This revision now requires changes to proceed.

Upon reflection, I don't think this is the right approach.

Desugaring any AttributedType in the return type seems like a really, really 
big hammer and could be an unexpected surprise for future attributed types 
where this is not the right behavior. I think a better approach for the 
nullability issue would be to update `lookThroughImplicitCasts()` in 
NullabilityChecker.cpp to look though `ExprWithCleanups` expressions just like 
it currently does for implicit casts.

What do you think?


https://reviews.llvm.org/D23236



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to