courbet added a comment. In D153131#4653362 <https://reviews.llvm.org/D153131#4653362>, @aaronpuchert wrote:
> In D153131#4653345 <https://reviews.llvm.org/D153131#4653345>, @aeubanks > wrote: > >> This is finding lots of real issues in code, which is awesome, but could I >> request that this be put under a separate warning flag so we can toggle off >> just the new functionality and turn it on as we clean our codebase? e.g. >> `-W[no-]thread-safety-analysis-return` > > Fine for me, but we might want to remove it again after one or two releases. > I'm not sure how to communicate that this is just a “transitory” flag. > > And it should be included by default in `-Wthread-safety-reference`, so that > users of that flag see the new warnings/errors, and can demote them to > warnings while fixing them. To emphasize the subflag status, I'd suggest > something like `-Wthread-safety-reference-return`. I also had some push back internally on adding this to the existing flag. I'm going to add `-Wthread-safety-reference-return`, can we start by not temporarily including it in `-Wthread-safety-reference` so that we can see how much work it it to fix those warnings ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
