hfinkel added inline comments.
================
Comment at: lib/Driver/ToolChains.cpp:2834
@@ +2833,3 @@
+ // If this tool chain is used for an OpenMP offloading device we have to make
+ // sure we always generate a shared library regardless the commands the user
+ // passed to the host. This is required because the runtime library requires
----------------
regardless the -> regardless of the
================
Comment at: lib/Driver/ToolChains.cpp:2836
@@ +2835,3 @@
+ // passed to the host. This is required because the runtime library requires
+ // to load the device image dynamically at run time.
+ if (DeviceOffloadKind == Action::OFK_OpenMP) {
----------------
requires to load -> is required to load
================
Comment at: lib/Driver/ToolChains.cpp:2854
@@ +2853,3 @@
+ case options::OPT_shared:
+ case options::OPT_static:
+ case options::OPT_fPIC:
----------------
And also?
case options::OPT_dynamic:
https://reviews.llvm.org/D21848
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
