aaron.ballman added a comment. Precommit CI is still finding some issues that boil down to:
# .---command stderr------------ # | C:\ws\src\clang\test\Modules/Inputs/System/usr/include\module.map:19:12: error: header 'stdckdint.h' not found # | 19 | header "stdckdint.h" # | | ^ # | C:\ws\src\clang\test\Modules/Inputs/System/usr/include\uses_other_constants.h:2:10: note: submodule of top-level module 'cstd' implicitly imported here # | 2 | #include <float.h> # | | ^ # | C:\ws\src\clang\test\Modules\cstd.m:4:9: fatal error: could not build module 'uses_other_constants' # | 4 | @import uses_other_constants; # | | ~~~~~~~^~~~~~~~~~~~~~~~~~~~ # | C:\ws\src\clang\test\Modules/Inputs/System/usr/include\module.map:19:12: error: header 'stdckdint.h' not found # | 19 | header "stdckdint.h" # | | ^ # | 3 errors generated. # `----------------------------- # error: command failed with exit status: 1 I commented on what I think needs to change to fix the issues. ================ Comment at: clang/test/Modules/Inputs/System/usr/include/module.map:17-21 + // In both directories (compiler support version wins, does not forward) + module stdckdint { + header "stdckdint.h" + } + ---------------- I think these changes should be removed, there is no `stdckdint.h` file in `test/Modules/Inputs/System/usr/include`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits