AlexVlx added a comment. In D155775#4652851 <https://reviews.llvm.org/D155775#4652851>, @ro wrote:
> In D155775#4652785 <https://reviews.llvm.org/D155775#4652785>, @AlexVlx wrote: > >> In D155775#4652780 <https://reviews.llvm.org/D155775#4652780>, @dyung wrote: >> >>> > > > >>> At this point, would it be easier to add a REQUIRES line for the target the >>> test should support rather than just whack-a-mole for the targets it does >>> not? >> >> Oh, it definitely would be MUCH easier to add a `REQUIRES` line, however I'd >> have had to have thought about that, which I did not, so thank you for the >> wake up call. I'll update this in a few minutes. > > Unfortunately, this is still not done after almost a day, leaving quite a > number of buildbots broken. Please fix or revert. Apologies, do you have an indication of which buildbots are still broken due to this change, after the most recent commit? The ones I was initially aware of, as well as those brought up here appear to pass at the moment, and glancing through the currently failing builds didn’t point to this as being the culprit (I could’ve simply missed it). Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
