MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:340 + HasRocThrustLibrary = !HIPRocThrustPathArg.empty() && + D.getVFS().exists(HIPRocThrustPathArg + "/thrust"); + HIPRocPrimPathArg = ---------------- AlexVlx wrote: > MaskRay wrote: > > Prefer `concat` so that if `HIPRocThrustPathArg` ends with `/`, we will not > > get `...//thrust`. > If you don't mind, I'll do this in a subsequent patch since it's just > annoying and not an outright error. The issue being that > RocmInstallationDetector is not a ToolChain and isn't `friend`ly to one > either, so `concat` is inaccessible. Addressing that would add a bit of > unrelated noise (looking through the file we probably want concat in more > places). Don't mind:) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
