hokein added inline comments. ================ Comment at: clang-move/ClangMove.cpp:62 @@ +61,3 @@ + return MakeAbsolutePath(SourceManager, FileEntry->getName()) == + AbsoluteFilePath; +} ---------------- ioeric wrote: > To generalize the function, maybe also remove dots in `AbsoluteFilePath`? `AbsoluteFilePath` has been removed dots, and the matcher here is only used internally by clang-move, so I'd prefer the current way here, if we meet the generalized case in the future, I will be happy to extend it.
https://reviews.llvm.org/D24922 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
