Prabhuk added inline comments.
================
Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109
+TEST(DataLayoutTest, UEFI) {
+ Triple TT = Triple("x86_64-unknown-uefi");
+
----------------
mbrkusanin wrote:
> Prabhuk wrote:
> > mbrkusanin wrote:
> > > This is giving me a linker error:
> > >
> > > $ ninja unittests/IR/IRTests
> > > ....
> > > /usr/bin/ld: unittests/IR/CMakeFiles/IRTests.dir/DataLayoutTest.cpp.o:
> > > undefined reference to symbol '_ZN4llvm6TripleC1ERKNS_5TwineE'
> > > /usr/bin/ld: ....../build/lib/libLLVMTargetParser.so.18git: error adding
> > > symbols: DSO missing from command line
> > >
> > > Adding TargetParser to link componenets in
> > > llvm/unittests/IR/CMakeLists.txt seems to fix it for me, but can you
> > > check please?
> > Thanks for bringing this to my attention. I am able to build and run the IR
> > tests from top of the tree without any failures. Let me take a closer look
> > on how to reproduce this.
> It seems only few buildbots fail with this same error:
> https://lab.llvm.org/buildbot/#/builders/57/builds/30211
> Not sure what is common between me and these buildbots.
>
> But I get the same error with lld as well:
>
> ld.lld: error: undefined symbol: llvm::Triple::Triple(llvm::Twine const&)
> />>> referenced by DataLayoutTest.cpp
> />>>
> unittests/IR/CMakeFiles/IRTests.dir/DataLayoutTest.cpp.o:((anonymous
> namespace)::DataLayoutTest_UEFI_Test::TestBody())
>
>
>
>
Thank you. I just reverted the change. I will reland this with an appropriate
fix to the link failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152206/new/
https://reviews.llvm.org/D152206
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
