================ @@ -239,6 +245,11 @@ bool RISCVInstructionSelector::select(MachineInstr &MI) { } case TargetOpcode::G_SEXT_INREG: return selectSExtInreg(MI, MIB); + case TargetOpcode::G_SELECT: + if (!selectSelect(MI, MIB, MRI)) + return false; + MI.eraseFromParent(); ---------------- michaelmaitland wrote:
Looks like other `select` functions (i.e. selectSExtInreg) do `MI.eraseFromParent();` in `selectXX`. Should we move this one into `selectSelect` in the `true` cases for consistency and simplification here? https://github.com/llvm/llvm-project/pull/67614 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits