================ @@ -1444,6 +1444,77 @@ llvm::Error ASTReader::ReadSourceManagerBlock(ModuleFile &F) { } } +std::optional<SourceLocation::UIntTy> +ASTReader::readSLocOffset(ModuleFile *F, unsigned Index) { ---------------- benlangmuir wrote:
Does every path that returns `std::nullopt` report an error? If so I would recommend returning `Expected<...>` instead of `optional` and then report the error in the caller. https://github.com/llvm/llvm-project/pull/66966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits