[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

For new revisions, prefer creating a PR at GitHub.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:903-904
   if (!TrackedNullability &&
-      getNullabilityAnnotation(ReturnType) == Nullability::Nullable) {
+      getNullabilityAnnotation(Call.getOriginExpr()->getType()) ==
+          Nullability::Nullable) {
     State = State->set<NullabilityMap>(Region, Nullability::Nullable);
----------------
I'm not sure if `getOriginExpr` is always non-null. How do you know?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159549/new/

https://reviews.llvm.org/D159549

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits