Timm =?utf-8?q?Bäder?= <tbae...@redhat.com>, Timm =?utf-8?q?Bäder?= <tbae...@redhat.com> Message-ID: In-Reply-To: <llvm/llvm-project/pull/66514/cl...@github.com>
erichkeane wrote: > If black is such a bad choice, then why is `noteColor` also black? > > https://github.com/llvm/llvm-project/blob/2ed813ff269664f2f9e78e9887c205b634226831/clang/lib/Frontend/TextDiagnostic.cpp#L27-L38 > > Check mate, atheists! > > As a side note, I've had problems with the "note:" in clang diagnostics being > invisible for... very long. You can see it being invisible in the second > screenshot I posted, too. I guess that answers my question about `GCC_COLORS`. Also, TIL about our 'note' being black! It always shows up as grey for me. I guess I don't mind choosing them, since we don't allow customizing other colors anyway. I DO like the idea of stealing the color scheme from some 'dark' theme, but I'm also not particularly opinionated about the colors we choose. https://github.com/llvm/llvm-project/pull/66514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
