hvdijk added a comment. In D86310#4648634 <https://reviews.llvm.org/D86310#4648634>, @nikic wrote:
> I'm happy to sign off on the x86-64 part here, but I'm less sure about > x86-32. If I understood correctly, the i128 alignment is raised there > exclusively to fix the "f128 legalized to i128 libcall" case -- is there any > other ABI requirement for i128 alignment on x86-32? Is raising i128 alignment > the right way to fix an f128 issue? GCC does not support `__int128` on x86-32, but clang has the `-fforce-enable-int128` option, and when that is used, it gives it the same 16-byte alignment that it does on x86-64, so even ignoring the `_Float128` issue, I think the change is right for x86-32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://reviews.llvm.org/D86310 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
