erichkeane wrote: Even after seeing your explaination, I don't find the images particularly useful or helpful. They are convoluted and confusing, and I don't think they add value here.
As far as being checked in: First, Git does really poorly with binary files. Second, if we were doing something like this, I'd request/require/demand/etc that it be published as a part of the documentation build, similar to how we do our Sphinx build documentation, not in-tree. It wouldn't require developers changing documentation to have the tool/dependency same as we don't really require that for Sphinx today, only a build-bot would be bothered. The synchronization of them is a massive concern that your explanation doesn't really cover: you say that checking them in is preferable since otherwise we have a dependency on 'ded', yet checking them in means the devs have to do it/have the tool. From the looks, 'ded' is a textual representation (though not a particularly maintainable looking one), that I'd suspect folks would want to make changes to with a text tool. In the end, the value proposition here doesn't check out. I can see SOME value to having a graphical AST representation, but I don't think this tool/interface is the way to do it, at least as far as I can see. https://github.com/llvm/llvm-project/pull/66436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
