aaron.ballman added a comment.

Thank you for working on this! You should also add a release note for the fix.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:6306-6310
+  ExprResult Converted = DefaultLvalueConversion(From);
+  QualType T = Converted.isUsable() ? Converted.get()->getType() : QualType();
   // If the expression already has a matching type, we're golden.
-  QualType T = From->getType();
   if (Converter.match(T))
     return DefaultLvalueConversion(From);
----------------
I think this is a slightly cleaner version of what you were doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159522/new/

https://reviews.llvm.org/D159522

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to