[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang
            
<details>
<summary>Changes</summary>
Before, constructor member initializers are shown as not covered. This adds 
coverage info for them.
--
Full diff: https://github.com/llvm/llvm-project/pull/66441.diff

2 Files Affected:

- (modified) clang/lib/CodeGen/CoverageMappingGen.cpp (+10-1) 
- (added) clang/test/CoverageMapping/ctor.cpp (+34) 


<pre>
diff --git a/clang/lib/CodeGen/CoverageMappingGen.cpp 
b/clang/lib/CodeGen/CoverageMappingGen.cpp
index dd81be6d96c6ee9..dbdb638d8774d4c 100644
--- a/clang/lib/CodeGen/CoverageMappingGen.cpp
+++ b/clang/lib/CodeGen/CoverageMappingGen.cpp
@@ -1032,11 +1032,20 @@ struct CounterCoverageMappingBuilder
     // lexer may not be able to report back precise token end locations for
     // these children nodes (llvm.org/PR39822), and moreover users will not be
     // able to see coverage for them.
+    Counter BodyCounter = getRegionCounter(Body);
     bool Defaulted = false;
     if (auto *Method = dyn_cast&amp;lt;CXXMethodDecl&amp;gt;(D))
       Defaulted = Method-&amp;gt;isDefaulted();
+    if (auto *Ctor = dyn_cast&amp;lt;CXXConstructorDecl&amp;gt;(D)) {
+      for (auto *Initializer : Ctor-&amp;gt;inits()) {
+        if (Initializer-&amp;gt;isWritten()) {
+          auto *Init = Initializer-&amp;gt;getInit();
+          propagateCounts(BodyCounter, Init);
+        }
+      }
+    }
 
-    propagateCounts(getRegionCounter(Body), Body,
+    propagateCounts(BodyCounter, Body,
                     /*VisitChildren=*/!Defaulted);
     assert(RegionStack.empty() &amp;amp;&amp;amp; &amp;quot;Regions entered 
but never exited&amp;quot;);
   }
diff --git a/clang/test/CoverageMapping/ctor.cpp 
b/clang/test/CoverageMapping/ctor.cpp
new file mode 100644
index 000000000000000..26debb43c4b5875
--- /dev/null
+++ b/clang/test/CoverageMapping/ctor.cpp
@@ -0,0 +1,34 @@
+// RUN: %clang_cc1 -mllvm -emptyline-comment-coverage=false 
-fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping 
-emit-llvm-only -main-file-name continue.c %s | FileCheck %s
+
+class A {
+public:
+    int a;
+    A(int a): a(a) {}
+};
+class B: public A {
+public:
+    int b;
+    int c;
+    B(int x, int y)         // CHECK:      _ZN1BC2Eii:
+    : A(x),                 // CHECK-NEXT: File 0, [[@LINE]]:7 -&amp;gt; 
[[@LINE]]:11 = #0
+                            // CHECK-NEXT: File 0, [[@LINE+1]]:7 -&amp;gt; 
[[@LINE+1]]:13 = #0
+    b(x == 0? 1: 2),        // CHECK-NEXT: File 0, [[@LINE]]:7 -&amp;gt; 
[[@LINE]]:19 = #0
+                            // CHECK-NEXT: Branch,File 0, [[@LINE-1]]:7 
-&amp;gt; [[@LINE-1]]:13 = #1, (#0 - #1)
+                            // CHECK-NEXT: Gap,File 0, [[@LINE-2]]:14 
-&amp;gt; [[@LINE-2]]:15 = #1
+                            // CHECK-NEXT: File 0, [[@LINE-3]]:15 -&amp;gt; 
[[@LINE-3]]:16 = #1
+                            // CHECK-NEXT: File 0, [[@LINE-4]]:18 -&amp;gt; 
[[@LINE-4]]:19 = (#0 - #1)
+                            // CHECK-NEXT: File 0, [[@LINE+2]]:7 -&amp;gt; 
[[@LINE+8]]:8 = #0
+                            // CHECK-NEXT: File 0, [[@LINE+7]]:10 -&amp;gt; 
[[@LINE+7]]:12 = #0
+    c([&amp;amp;]() {               // CHECK:      _ZZN1BC1EiiENKUlvE_clEv:
+                            // CHECK-NEXT: File 0, [[@LINE-1]]:13 -&amp;gt; 
[[@LINE+5]]:6 = #0
+                            // CHECK-NEXT: File 0, [[@LINE+1]]:13 -&amp;gt; 
[[@LINE+1]]:19 = #0
+        if (y == 0)         // CHECK-NEXT: Branch,File 0, [[@LINE]]:13 
-&amp;gt; [[@LINE]]:19 = #1, (#0 - #1)
+            return 1;       // CHECK-NEXT: Gap,File 0, [[@LINE-1]]:20 
-&amp;gt; [[@LINE]]:13 = #1
+        return 2;           // CHECK-NEXT: File 0, [[@LINE-1]]:13 -&amp;gt; 
[[@LINE-1]]:21 = #1
+    }()) {}                 // CHECK-NEXT: Gap,File 0, [[@LINE-2]]:22 
-&amp;gt; [[@LINE-1]]:9 = (#0 - #1)
+};                          // CHECK-NEXT: File 0, [[@LINE-2]]:9 -&amp;gt; 
[[@LINE-2]]:17 = (#0 - #1)
+
+int main() {
+    B b(1,2);
+    return 0;
+}
</pre>
</details>


https://github.com/llvm/llvm-project/pull/66441
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits