dcoughlin added a comment. This is awesome! I have some minor comments on the dealloc notes. It is also fine to remove them entirely; we can add them in a later commit.
================ Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:604 @@ -588,1 +603,3 @@ + addExtraNoteForDecl(BR, "The property is declared here", PropDecl); + ---------------- To be consistent with the rest of clang, I think it is better to remove the "The". That is: "Property is declared here" and "Property is synthesized here". ================ Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:733 @@ -712,1 +732,3 @@ + addExtraNoteForDecl(BR, "The property is declared here", PropDecl); + ---------------- Is it possible to factor this out so we only have the hard-coded note text for each of "declared"/"synthesized" in one spot? This will make it easier to update the text if we decide to change it. https://reviews.llvm.org/D24278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
