kadircet added a comment. In D159263#4638199 <https://reviews.llvm.org/D159263#4638199>, @danix800 wrote:
> If we have further plans from upstream on these checker/clang-format related > logic, I can wait and abandon this revision. Not at the moment, so please don't! > Or if such issue does need fixing then coud you take a look at the previous > diff 1 <https://reviews.llvm.org/D159263?id=554947> > which uses an internal set to prevent this issue? Yes, I think that approach makes sense. But we should make it conditional on `areDiagsSelfContained` (basically de-duplicate only when diags are not self contained). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159263/new/ https://reviews.llvm.org/D159263 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
