omtcyfz added inline comments. ================ Comment at: change-namespace/ChangeNamespace.cpp:448 @@ +447,3 @@ + continue; + const std::string &FilePath = FileAndNsMoves.first; + auto &Replaces = FileToReplacements[FilePath]; ---------------- ioeric wrote: > omtcyfz wrote: > > `StringRef` here too. > If this was a `StringRef`, then each map access would require an implicit > conversion from `StringRef` to `std::string`, which is expensive. And this is > already a reference anyway. Ah, I see. Yes, that's true. Sorry.
https://reviews.llvm.org/D24183 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
