[PATCH] D159362: [clang][AST][DeclPrinter] Change "__attribute__" AST printing location for the sake of GCC compatibility.

[Mateusz Stachyra via Phabricator via cfe-commits]

mstachyraa created this revision.
Herald added a project: All.
mstachyraa requested review of this revision.
Herald added a subscriber: wangpc.
Herald added a project: clang.

When printing C representation of AST, clang puts the "__attribute__" elements 
after the name of printed function.
In order for the generated code to be GCC compatible, these attributes should 
be put at the beginning of function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159362

Files:
  clang/lib/AST/DeclPrinter.cpp


Index: clang/lib/AST/DeclPrinter.cpp
===================================================================
--- clang/lib/AST/DeclPrinter.cpp
+++ clang/lib/AST/DeclPrinter.cpp
@@ -612,6 +612,8 @@
          I < NumTemplateParams; ++I)
       printTemplateParameters(D->getTemplateParameterList(I));
   }
+  
+  prettyPrintAttributes(D);
 
   CXXConstructorDecl *CDecl = dyn_cast<CXXConstructorDecl>(D);
   CXXConversionDecl *ConversionDecl = dyn_cast<CXXConversionDecl>(D);
@@ -774,8 +776,6 @@
     Ty.print(Out, Policy, Proto);
   }
 
-  prettyPrintAttributes(D);
-
   if (D->isPure())
     Out << " = 0";
   else if (D->isDeletedAsWritten())



Index: clang/lib/AST/DeclPrinter.cpp
===================================================================
--- clang/lib/AST/DeclPrinter.cpp
+++ clang/lib/AST/DeclPrinter.cpp
@@ -612,6 +612,8 @@
          I < NumTemplateParams; ++I)
       printTemplateParameters(D->getTemplateParameterList(I));
   }
+  
+  prettyPrintAttributes(D);
 
   CXXConstructorDecl *CDecl = dyn_cast<CXXConstructorDecl>(D);
   CXXConversionDecl *ConversionDecl = dyn_cast<CXXConversionDecl>(D);
@@ -774,8 +776,6 @@
     Ty.print(Out, Policy, Proto);
   }
 
-  prettyPrintAttributes(D);
-
   if (D->isPure())
     Out << " = 0";
   else if (D->isDeletedAsWritten())

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits