danix800 added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp:34 + if (auto SSize = + SVB.convertToArrayIndex(*Size).getAs<DefinedOrUnknownSVal>()) + return *SSize; ---------------- donat.nagy wrote: > I think it's a good convention if `getDynamicExtent()` will always return > concrete values as `ArrayIndexTy`. (If I didn't miss some very obscure case, > then this will be true when this commit is merged.) Could you elaborate this a bit more please? Do you mean by `nonloc::ConcreteInt` rather than `DefinedOrUnknownSVal`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158707/new/ https://reviews.llvm.org/D158707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
