FYI I had to revert this in r281562 because of: * http://llvm.org/PR30341 which breaks the LLVM build. * http://llvm.org/PR30391 which breaks ABI compatibility when libc++.so is compiled with GCC.
I'm working on fixing these issues so that this patch may be recommitted. The GCC issue also made worse by r278356 but I don't think we need to revert it (at least right now). /Eric On Thu, Sep 8, 2016 at 8:31 AM, Aditya Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hiraditya > Date: Thu Sep 8 09:31:44 2016 > New Revision: 280944 > > URL: http://llvm.org/viewvc/llvm-project?rev=280944&view=rev > Log: > Added 'inline' attribute to basic_string's destructor > > Author: laxmansole > > Reviewers: howard.hinnant > mclow.lists > Subscribers: EricWF, flyingforyou, evandro > > Differential Revision: https://reviews.llvm.org/D22834 > > Currently basic_string's destructor is not getting inlined. So adding > 'inline' attribute to ~basic_string(). > Worked in collaboration with Aditya Kumar. > > Modified: > libcxx/trunk/include/string > > Modified: libcxx/trunk/include/string > URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/ > string?rev=280944&r1=280943&r2=280944&view=diff > ============================================================ > ================== > --- libcxx/trunk/include/string (original) > +++ libcxx/trunk/include/string Thu Sep 8 09:31:44 2016 > @@ -1798,6 +1798,7 @@ basic_string<_CharT, _Traits, _Allocator > #endif // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS > > template <class _CharT, class _Traits, class _Allocator> > +inline _LIBCPP_INLINE_VISIBILITY > basic_string<_CharT, _Traits, _Allocator>::~basic_string() > { > #if _LIBCPP_DEBUG_LEVEL >= 2 > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
