dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195
SymbolReference Context;
- auto Record = dyn_cast<RecordDecl>(Decl->getDeclContext());
+ auto Record = cast<RecordDecl>(Decl->getDeclContext());
Context.Name = Record->getName();
----------------
NIT: It's not immediately obvious that the check `if
(Decl->isStaticDataMember())` guarantees that `Decl->getDeclContext()` is a
`RecordDecl`. Would you mind adding a comment static that?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158671/new/
https://reviews.llvm.org/D158671
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
