[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:590
+      Builder.defineMacro("__HIPSTDPAR__");
+      if (!LangOpts.CUDAIsDevice)
+        Builder.defineMacro("__HIPSTDPAR_INTERPOSE_ALLOC__");
----------------
We usually prefer defining the macro consistently in host and device 
compilation to avoid the chance of violation of ODR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155826/new/

https://reviews.llvm.org/D155826

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits