v.g.vassilev added a comment.

This is quite exciting! Most of it looks already good enough to me. See inline 
comment.



================
Comment at: clang/lib/Interpreter/WASM.cpp:79
+  int Result =
+      lld::wasm::link(LinkerArgs, llvm::outs(), llvm::errs(), false, false);
+  if (!Result)
----------------
I am not sure how we can solve that dependency here. Worst case scenario, could 
we check if `lld` is installed and make a system call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158140/new/

https://reviews.llvm.org/D158140

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to