v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.

This change looks reasonable to me.



================
Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:74
+// expected-error@-1 2 {{'Inner' is a private member of 'PR13642'}}
+
 // Deduction guide
----------------
Hahnfeld wrote:
> v.g.vassilev wrote:
> > Could we move the diagnostic-producing cases in a separate file?
> We could, but I'm actually not a big fan because it moves the expected 
> failing test away from the related disambiguation tests above...
Okay, fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157838/new/

https://reviews.llvm.org/D157838

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to