nemanjai added a comment. In D158066#4593961 <https://reviews.llvm.org/D158066#4593961>, @qiucf wrote:
> CC @amyk @quinnp Any comments about the naming? > > I see some `__builtin_ppc_xxx` are aliased into `__builtin_xxx` by > `defineXLCompatMacros`. But these are not XL-compatible builtins, and the > macros do not always work. It should be perfectly fine to provide pre-defined macros for these to match GCC on PowerPC. The reason we went with the macro solution is to avoid polluting the builtins namespace for other targets. Also, please add some C++ tests for these PPC wrappers so that we aren't surprised again when someone tries to use these in their C++ code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158066/new/ https://reviews.llvm.org/D158066 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
