This revision was automatically updated to reflect the committed changes. Closed by commit rG3e69886dd012: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr() (authored by nridge).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158248/new/ https://reviews.llvm.org/D158248 Files: clang-tools-extra/clangd/InlayHints.cpp Index: clang-tools-extra/clangd/InlayHints.cpp =================================================================== --- clang-tools-extra/clangd/InlayHints.cpp +++ clang-tools-extra/clangd/InlayHints.cpp @@ -273,7 +273,7 @@ return getSimpleName(E->getMember()).str(); } std::string - VisitDependentScopeMemberExpr(const DependentScopeDeclRefExpr *E) { + VisitDependentScopeDeclRefExpr(const DependentScopeDeclRefExpr *E) { return getSimpleName(E->getDeclName()).str(); } std::string VisitCXXFunctionalCastExpr(const CXXFunctionalCastExpr *E) { @@ -534,7 +534,7 @@ // Do not show parameter hints for operator calls written using operator // syntax or user-defined literals. (Among other reasons, the resulting - // hints can look awkard, e.g. the expression can itself be a function + // hints can look awkward, e.g. the expression can itself be a function // argument and then we'd get two hints side by side). if (isa<CXXOperatorCallExpr>(E) || isa<UserDefinedLiteral>(E)) return true;
Index: clang-tools-extra/clangd/InlayHints.cpp =================================================================== --- clang-tools-extra/clangd/InlayHints.cpp +++ clang-tools-extra/clangd/InlayHints.cpp @@ -273,7 +273,7 @@ return getSimpleName(E->getMember()).str(); } std::string - VisitDependentScopeMemberExpr(const DependentScopeDeclRefExpr *E) { + VisitDependentScopeDeclRefExpr(const DependentScopeDeclRefExpr *E) { return getSimpleName(E->getDeclName()).str(); } std::string VisitCXXFunctionalCastExpr(const CXXFunctionalCastExpr *E) { @@ -534,7 +534,7 @@ // Do not show parameter hints for operator calls written using operator // syntax or user-defined literals. (Among other reasons, the resulting - // hints can look awkard, e.g. the expression can itself be a function + // hints can look awkward, e.g. the expression can itself be a function // argument and then we'd get two hints side by side). if (isa<CXXOperatorCallExpr>(E) || isa<UserDefinedLiteral>(E)) return true;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits