awarzynski created this revision. awarzynski added a reviewer: kiranchandramohan. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang.
Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158309 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-help-hidden.f90 flang/test/Driver/driver-help.f90 flang/test/Driver/misc-flags.f90 Index: flang/test/Driver/misc-flags.f90 =================================================================== --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 =================================================================== --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U <macro> Undefine macro <macro> ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl,<arg> Pass the comma separated arguments in <arg> to the linker ! HELP-NEXT: -W<warning> Enable the specified warning ! HELP-NEXT: -Xflang <arg> Pass <arg> to the flang compiler ! HELP-NEXT: -x <language> Treat subsequent input files as having type <language> Index: flang/test/Driver/driver-help-hidden.f90 =================================================================== --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U <macro> Undefine macro <macro> ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl,<arg> Pass the comma separated arguments in <arg> to the linker ! CHECK-NEXT: -W<warning> Enable the specified warning ! CHECK-NEXT: -Xflang <arg> Pass <arg> to the flang compiler ! CHECK-NEXT: -x <language> Treat subsequent input files as having type <language> Index: clang/include/clang/Driver/Options.td =================================================================== --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -912,7 +912,8 @@ HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group<W_Group>, Visibility<[ClangOption, CC1Option]>; -def Wl_COMMA : CommaJoined<["-"], "Wl,">, Flags<[LinkerInput, RenderAsInput]>, +def Wl_COMMA : CommaJoined<["-"], "Wl,">, Visibility<[ClangOption, FlangOption]>, + Flags<[LinkerInput, RenderAsInput]>, HelpText<"Pass the comma separated arguments in <arg> to the linker">, MetaVarName<"<arg>">, Group<Link_Group>; // FIXME: This is broken; these should not be Joined arguments.
Index: flang/test/Driver/misc-flags.f90 =================================================================== --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 =================================================================== --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U <macro> Undefine macro <macro> ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl,<arg> Pass the comma separated arguments in <arg> to the linker ! HELP-NEXT: -W<warning> Enable the specified warning ! HELP-NEXT: -Xflang <arg> Pass <arg> to the flang compiler ! HELP-NEXT: -x <language> Treat subsequent input files as having type <language> Index: flang/test/Driver/driver-help-hidden.f90 =================================================================== --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U <macro> Undefine macro <macro> ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl,<arg> Pass the comma separated arguments in <arg> to the linker ! CHECK-NEXT: -W<warning> Enable the specified warning ! CHECK-NEXT: -Xflang <arg> Pass <arg> to the flang compiler ! CHECK-NEXT: -x <language> Treat subsequent input files as having type <language> Index: clang/include/clang/Driver/Options.td =================================================================== --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -912,7 +912,8 @@ HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group<W_Group>, Visibility<[ClangOption, CC1Option]>; -def Wl_COMMA : CommaJoined<["-"], "Wl,">, Flags<[LinkerInput, RenderAsInput]>, +def Wl_COMMA : CommaJoined<["-"], "Wl,">, Visibility<[ClangOption, FlangOption]>, + Flags<[LinkerInput, RenderAsInput]>, HelpText<"Pass the comma separated arguments in <arg> to the linker">, MetaVarName<"<arg>">, Group<Link_Group>; // FIXME: This is broken; these should not be Joined arguments.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
