probinson added inline comments.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:423 + if (!CSInfo) { + SmallString<64> Checksum; + std::optional<llvm::DIFile::ChecksumKind> CSKind = ---------------- In the final commit, `Checksum` is outside the `if` so that its lifetime persists to the end of the function (specifically, past the `createFile` call). `CSInfo` holds a StringRef to this string, not the string itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits