awarzynski created this revision.
awarzynski added reviewers: DavidSpickett, kiranchandramohan.
Herald added a reviewer: sscalpone.
Herald added a project: All.
awarzynski requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
This is a partial revert of https://reviews.llvm.org/D157837 - it turns
out that the LLVM test suite needs to be updated first not to use any of
the unsupported Flang options:
- https://github.com/llvm/llvm-test-suite
Sample errors:
flang-new: error: unknown argument: '-fbounds-check'
flang-new: error: unknown argument: '-fcheck=all'
flang-new: error: unknown argument: '-fcheck-array-temporaries'
Once the test suite is updated, we can restore the reverted setting.
Broken bot:
- https://lab.llvm.org/buildbot/#/builders/197/builds/9001
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158289
Files:
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
===================================================================
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -6494,8 +6494,8 @@
return llvm::opt::Visibility(options::CLOption);
if (IsDXCMode())
return llvm::opt::Visibility(options::DXCOption);
- if (IsFlangMode()) {
- return llvm::opt::Visibility(options::FlangOption);
+ if (IsFlangMode()) {
+ return llvm::opt::Visibility(options::ClangOption | options::FlangOption);
}
return llvm::opt::Visibility(options::ClangOption);
}
Index: clang/lib/Driver/Driver.cpp
===================================================================
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -6494,8 +6494,8 @@
return llvm::opt::Visibility(options::CLOption);
if (IsDXCMode())
return llvm::opt::Visibility(options::DXCOption);
- if (IsFlangMode()) {
- return llvm::opt::Visibility(options::FlangOption);
+ if (IsFlangMode()) {
+ return llvm::opt::Visibility(options::ClangOption | options::FlangOption);
}
return llvm::opt::Visibility(options::ClangOption);
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
