FreddyYe marked an inline comment as done. FreddyYe added inline comments.
================ Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: ---------------- RKSimon wrote: > Why not handle this above (below tremont) as the next in the *mont series? Good catch. This isn't a short story... In short words, it was to save codes in predefined-arch-macros.c. If set gracemont as a series of atom processors, macros like `corei7`(predefined-arch-macros.c:2061-2062) won't be generated by `-march=gracemont`, and for history reasons, atom series processors defined some extra macros of their names, like "tremont", "goldmont", ... but these macros are not used any longer IIRC. So I decided to define gracemont as a non-atom series one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
