MaskRay added a comment.

In D158137#4594181 <https://reviews.llvm.org/D158137#4594181>, @dexonsmith 
wrote:

> LGTM.
>
> Perhaps as a follow-up, rename warn_drv_overriding_flag_option to have “t” in 
> it?

Thanks! I agree. d9ad0681fad9a98f43d9baddb95d505b37153c48 (2013) renamed 
`warn_drv_overriding_t_option` to `warn_drv_overriding_flag_option`.
Perhaps the original name `warn_drv_overriding_t_option` should be restored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158137/new/

https://reviews.llvm.org/D158137

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to