ZijunZhao added inline comments.
================ Comment at: clang/test/C/C2x/n2359.c:40 +#error "__STDC_VERSION_STDCKDINT_H__ not defined" +// expected-error@-1 {{"__STDC_VERSION_STDCKDINT_H__ not defined"}} +#endif ---------------- enh wrote: > don't you need another test somewhere that this _is_ defined under some > circumstances? (and a definition in the header itself!) I follow the cases like `__STDC_VERSION_LIMITS_H__` and `__STDC_VERSION_STDATOMIC_H__` . They are not defined in the <limits.h> or <stdatomic.h>. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits