victorkingi added inline comments.
================ Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:169-171 + clang::ProcessWarningOptions(flang->getDiagnostics(), + flang->getDiagnosticOpts()); + ---------------- victorkingi wrote: > awarzynski wrote: > > Is this calling > > https://github.com/llvm/llvm-project/blob/c52d9509d40d3048914b144618232213e6076e05/clang/include/clang/Basic/Diagnostic.h#L1840-L1842? > > That's part of the `clangBasic` library. The overall goal in the driver is > > to reduce the dependency on Clang and this would be a step in the opposite > > direction. IIUC, we only need a small subset of that function, right? > Yes, we only need a small subset. I'll create a static function in this file > to avoid the dependence > Yes, we only need a small subset. I'll create a static function in this file > to avoid the dependence I mean normal function not static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
