5chmidti created this revision.
5chmidti added a project: clang-tools-extra.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
5chmidti requested review of this revision.
Herald added a subscriber: cfe-commits.
Differential https://reviews.llvm.org/D145477 removed the check for `(yaml and
args.export_fixes)` in line 303 to skip looking for the
`clang-apply-replacements` binary. However, the `tmpdir` variable was set in
this true branch when exporting fixes and therefore is `None` when invoking
run-clang-tidy with `run-clang-tidy -p . -export-fixes fixes.yaml`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D157773
Files:
clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===================================================================
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -389,6 +389,8 @@
clang_apply_replacements_binary = find_binary(
args.clang_apply_replacements_binary, "clang-apply-replacements",
build_path
)
+
+ if args.fix or (yaml and args.export_fixes):
tmpdir = tempfile.mkdtemp()
try:
Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===================================================================
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -389,6 +389,8 @@
clang_apply_replacements_binary = find_binary(
args.clang_apply_replacements_binary, "clang-apply-replacements", build_path
)
+
+ if args.fix or (yaml and args.export_fixes):
tmpdir = tempfile.mkdtemp()
try:
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
