strimo378 added a comment. @aaron.ballman I had today a teams meeting with @giulianobelinassi and we discussed both patches as well as that we want to work together in improving AST print. Both patches are fine for us since they improve the attribute printing. The features of the respective other patch can be easily integrated with minimal changes in a subsequent smaller patch. We further think that there are a lot more cases of attributes that we need to consider that we do not know atm.
I think we should go one with patch that has the higher probability to get landed soon. Since this branch had a lot more reviews, I suggest we go further with this patch. I further suggest to keep it simple and remove the tblgen part and add it in an subsequent patch once we know all cases and requirements. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
