ilya-biryukov added inline comments.

================
Comment at: clang/lib/Sema/SemaOverload.cpp:967
                S.getScopeForContext(EqFD->getEnclosingNamespaceContext()));
   NonMembers.suppressAccessDiagnostics();
   for (NamedDecl *Op : NonMembers) {
----------------
I believe we should be able to expose the same errorenous behavior here, but I 
did not come up with a test yet, so did not change it yet.
We should update it and come up with a test before the change lands.

But I still wanted to get early feedback on the direction of this patch, so 
sending for review right away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157708/new/

https://reviews.llvm.org/D157708

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D157708: ... Ilya Biryukov via Phabricator via cfe-commits
    • [PATCH] D157... Ilya Biryukov via Phabricator via cfe-commits
    • [PATCH] D157... Ilya Biryukov via Phabricator via cfe-commits
    • [PATCH] D157... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D157... Ilya Biryukov via Phabricator via cfe-commits

Reply via email to