ahatanak updated this revision to Diff 549165. ahatanak added a comment. Mention that the linker bug has been fixed.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157520/new/ https://reviews.llvm.org/D157520 Files: clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -5578,8 +5578,11 @@ } // Enable -mconstructor-aliases except on darwin, where we have to work around - // a linker bug (see https://openradar.appspot.com/7198997), and CUDA device - // code, where aliases aren't supported. + // a linker bug where aliasing symbols are not moved to the new locations when + // the aliased symbol is moved, and CUDA device code, where aliases aren't + // supported. + // FIXME: Enable this on Darwin after extensive testing. The linker bug + // mentioned above has been fixed. if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX()) CmdArgs.push_back("-mconstructor-aliases");
Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -5578,8 +5578,11 @@ } // Enable -mconstructor-aliases except on darwin, where we have to work around - // a linker bug (see https://openradar.appspot.com/7198997), and CUDA device - // code, where aliases aren't supported. + // a linker bug where aliasing symbols are not moved to the new locations when + // the aliased symbol is moved, and CUDA device code, where aliases aren't + // supported. + // FIXME: Enable this on Darwin after extensive testing. The linker bug + // mentioned above has been fixed. if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX()) CmdArgs.push_back("-mconstructor-aliases");
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
