yronglin added a comment.

In D153701#4575056 <https://reviews.llvm.org/D153701#4575056>, 
@hubert.reinterpretcast wrote:

> In D153701#4563919 <https://reviews.llvm.org/D153701#4563919>, @yronglin 
> wrote:
>
>> The gap between these two numbers is very large. So I'think we can create 
>> additional materializations only within for-range initializers. I'm not sure 
>> if I can find a way to only create materializes for temporaries that need to 
>> have an extended lifetime, WDYT?
>
> @rsmith asked for something slightly different (but I am not sure how to 
> collect that info): He wanted the AST size delta.
>
> For what we have, I think the detailed results table would be more useful if 
> we add some size metric for the files and the increase expressed as a 
> percentage. Perhaps sorting by file size would help contextualize the 
> significance of the percentage change.

Thanks to Aaron's suggestion in Discard, the initial idea was to count the 
number of `MaterializedTemporaryExpr` created in the process of building 
llvm-project, and then calculate the precise memory increment data, without 
being affected by the operating system state. Maybe I can refine this table, 
add a column to show the memory increment  percentage change of each file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153701/new/

https://reviews.llvm.org/D153701

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to