aaron.ballman added a comment. I'm curious to hear what others think about this (especially @rnk and @hans). I think this is the correct approach -- `-fms-extensions` is separate from the Windows target; for example, users can enable `__declspec` attributes this way: https://godbolt.org/z/GEa3oqWPb So I think that it makes sense to define `_MSC_EXTENSIONS` whenever `-fms-extensions` is enabled. But I'm not certain if others feel the same way or not or if this approach will cause problems anyone can think of.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157334/new/ https://reviews.llvm.org/D157334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
